Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use centralized script for transform strain names #182

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

j23414
Copy link
Contributor

@j23414 j23414 commented Sep 20, 2023

Description of proposed changes

transform-strain-names script has been moved to the centralized ingest repo. Remove the copy in this repo and update references.

Related issue(s)

Testing

  •  Checks pass
  •  cd ingest; nextstrain build --cpus 1 . data/metadata.tsv runs locally

Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending successful tests!

subrepo:
  subdir:   "ingest/vendored"
  merged:   "c02fa81"
upstream:
  origin:   "https://github.com/nextstrain/ingest"
  branch:   "main"
  commit:   "c02fa81"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
@j23414 j23414 force-pushed the centralize_transform_strain_names branch from b078b4b to 52d75f4 Compare September 20, 2023 23:44
@j23414
Copy link
Contributor Author

j23414 commented Sep 21, 2023

Tests pass, and metadata.tsv shows no differences.

diff old_monkeypox/ingest/data/metadata.tsv new_monkeypox/ingest/data/metadata.tsv

@j23414 j23414 merged commit 50d200c into master Sep 21, 2023
4 checks passed
@j23414 j23414 deleted the centralize_transform_strain_names branch September 21, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants